osmo-mgw[master]: client: add an optional FSM interface

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Feb 8 09:38:48 UTC 2018


Patch Set 9:

(1 comment)

https://gerrit.osmocom.org/#/c/5881/9/src/libosmo-mgcp-client/mgcp_client_fsm.c
File src/libosmo-mgcp-client/mgcp_client_fsm.c:

Line 443: static void fsm_cleanup_cb(struct osmo_fsm_inst *fi, enum osmo_fsm_term_cause cause)
> It exits always through the cleanup_cb, I thought that this is what the cle
I think we should have an unconditional DLCX in erroneous cases based on the osmo_fsm_term_cause, yes.  It cannot hurt but might help to recover in some cases.


-- 
To view, visit https://gerrit.osmocom.org/5881
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I887ce0c15a831dffeb6251a975337b83942af566
Gerrit-PatchSet: 9
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list