osmo-ttcn3-hacks[master]: msc: convert bssmap chipher to rsl chiper representation

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Feb 8 09:25:03 UTC 2018


Patch Set 1: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/#/c/6314/1//COMMIT_MSG
Commit Message:

Line 11: A51 the values match up by coincidence, from A53 on they differ.
from A5/2 onwards.


https://gerrit.osmocom.org/#/c/6314/1/bsc/MSC_ConnectionHandler.ttcn
File bsc/MSC_ConnectionHandler.ttcn:

Line 330: 	if (alg_bssmap == '01'O) {
you could have used a 'select ()' statement, which is similar to 'switch/case' in C. No need to rewrite, but next time it is a less verbose syntax...


-- 
To view, visit https://gerrit.osmocom.org/6314
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I274c1ff0b5636c48411f994f918e783b468cb3be
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list