[MERGED] osmo-ttcn3-hacks[master]: bsc: fix f_establish_fully() for expected assignment failures

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Feb 8 09:23:04 UTC 2018


Harald Welte has submitted this change and it was merged.

Change subject: bsc: fix f_establish_fully() for expected assignment failures
......................................................................


bsc: fix f_establish_fully() for expected assignment failures

The altstep guard statements are to restrictive so they do not
match on an expected assignment failure anymore.

- Add a new altstep for expected assignment failures.

Change-Id: I78b839f0bcb7e2da61bff0add3abc452bfea40a2
---
M bsc/MSC_ConnectionHandler.ttcn
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/bsc/MSC_ConnectionHandler.ttcn b/bsc/MSC_ConnectionHandler.ttcn
index a7f4d71..5a645bd 100644
--- a/bsc/MSC_ConnectionHandler.ttcn
+++ b/bsc/MSC_ConnectionHandler.ttcn
@@ -517,6 +517,7 @@
 	var PDU_BSSAP bssap;
 	timer T := 10.0;
 	var boolean exp_compl := ischosen(exp_ass_cpl.pdu.bssmap.assignmentComplete);
+	var boolean exp_fail := ischosen(exp_ass_cpl.pdu.bssmap.assignmentFailure);
 	var ExpectCriteria mgcpcrit := {
 		connid := omit,
 		endpoint := omit,
@@ -556,6 +557,9 @@
 	 (not st.is_assignment and st.modify_done)] BSSAP.receive(exp_ass_cpl) -> value bssap {
 		setverdict(pass);
 		}
+	[exp_fail] BSSAP.receive(exp_ass_cpl) -> value bssap {
+		setverdict(pass);
+		}
 	[(st.is_assignment and st.assignment_done or
 	 (not st.is_assignment and st.modify_done)) and
 	 exp_compl] BSSAP.receive(tr_BSSMAP_AssignmentComplete) {

-- 
To view, visit https://gerrit.osmocom.org/6313
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I78b839f0bcb7e2da61bff0add3abc452bfea40a2
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list