[MERGED] osmo-msc[master]: Fix whitespace issues

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Feb 6 19:36:03 UTC 2018


Harald Welte has submitted this change and it was merged.

Change subject: Fix whitespace issues
......................................................................


Fix whitespace issues

We don't usually put space before in-place increment or decrement. Let's
make code look similar to other Osmocom projects.

Change-Id: I5962431ad16c97e412939dc1b8949f6361a5c26e
---
M src/libcommon/oap_client.c
M src/libmsc/sms_queue.c
M src/libvlr/vlr.c
M tests/msc_vlr/msc_vlr_tests.c
M tests/sms_queue/sms_queue_test.c
5 files changed, 6 insertions(+), 6 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libcommon/oap_client.c b/src/libcommon/oap_client.c
index 39055ab..7154baa 100644
--- a/src/libcommon/oap_client.c
+++ b/src/libcommon/oap_client.c
@@ -257,7 +257,7 @@
 		     "OAP registration failed\n");
 		state->state = OAP_INITIALIZED;
 		if (state->registration_failures < 3) {
-			state->registration_failures ++;
+			state->registration_failures++;
 			return oap_client_register(state, msg_tx);
 		}
 		return -11;
diff --git a/src/libmsc/sms_queue.c b/src/libmsc/sms_queue.c
index 39a81f6..7d59787 100644
--- a/src/libmsc/sms_queue.c
+++ b/src/libmsc/sms_queue.c
@@ -216,7 +216,7 @@
 		sms = db_sms_get_next_unsent_rr_msisdn(net, last_msisdn, 9);
 		if (!sms) {
 			last_msisdn[0] = '\0';
-			wrapped ++;
+			wrapped++;
 			continue;
 		}
 
diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c
index 2b9e3b2..96627ed 100644
--- a/src/libvlr/vlr.c
+++ b/src/libvlr/vlr.c
@@ -595,7 +595,7 @@
 		}
 		vsub->auth_tuples[i].vec = gsup->auth_vectors[i];
 		vsub->auth_tuples[i].key_seq = key_seq;
-		got_tuples ++;
+		got_tuples++;
 	}
 
 	LOGVSUBP(LOGL_DEBUG, vsub, "Received %u auth tuples\n", got_tuples);
diff --git a/tests/msc_vlr/msc_vlr_tests.c b/tests/msc_vlr/msc_vlr_tests.c
index 4544429..713bb16 100644
--- a/tests/msc_vlr/msc_vlr_tests.c
+++ b/tests/msc_vlr/msc_vlr_tests.c
@@ -826,8 +826,8 @@
 void run_tests(int nr)
 {
 	int test_nr;
-	nr --; /* arg's first test is 1, in here it's 0 */
-	for (test_nr = 0; msc_vlr_tests[test_nr]; test_nr ++) {
+	nr--; /* arg's first test is 1, in here it's 0 */
+	for (test_nr = 0; msc_vlr_tests[test_nr]; test_nr++) {
 		if (nr >= 0 && test_nr != nr)
 			continue;
 
diff --git a/tests/sms_queue/sms_queue_test.c b/tests/sms_queue/sms_queue_test.c
index 0ff636e..641cc5f 100644
--- a/tests/sms_queue/sms_queue_test.c
+++ b/tests/sms_queue/sms_queue_test.c
@@ -107,7 +107,7 @@
 		fake_sms.receiver = fake_sms_db[i].vsub_attached? &arbitrary_vsub : NULL;
 		osmo_strlcpy(fake_sms.text, fake_sms_db[i].msisdn, sizeof(fake_sms.text));
 		if (fake_sms_db[i].vsub_attached)
-			fake_sms_db[i].nr_of_sms --;
+			fake_sms_db[i].nr_of_sms--;
 		return &fake_sms;
 	}
 	return NULL;

-- 
To view, visit https://gerrit.osmocom.org/6308
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5962431ad16c97e412939dc1b8949f6361a5c26e
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list