libosmocore[master]: Add macros for all ACC bit flags in the rach control IE.

Stefan Sperling gerrit-no-reply at lists.osmocom.org
Tue Feb 6 12:58:15 UTC 2018


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/6286/1/include/osmocom/gsm/protocol/gsm_04_08.h
File include/osmocom/gsm/protocol/gsm_04_08.h:

Line 464: #define GSM48_RACH_CTRL_ACC15_BARRED		0x80
> That's rather odd location for defines. Can we place it outside of struct d
Sure, if you prefer that.

I'm very much used to defining flags below the variable which contains them because it makes it obvious where those flags belong.

If we move it outside I would rename them to e.g. "GSM48_RACH_CTRL_T2_ACC15_BARRED' to avoid confusion about whether this flag belongs to t2 or t3.

Would you agree with that?


-- 
To view, visit https://gerrit.osmocom.org/6286
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f0a65c2980f86eb5c43f3bebe727f4d4d973163
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list