osmo-mgw[master]: Turn libosmo-mgcp into local, non-installed library

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Feb 5 22:41:12 UTC 2018


Patch Set 2: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/6270/2/src/osmo-mgw/Makefile.am
File src/osmo-mgw/Makefile.am:

Line 11: 	$(LIBOSMOGSM_CFLAGS) \
> this seems non-related to the patch.
it is related, like the other hunks.  Currently, libosmo-mgcp.so carries a dependency to libosmogsm.so.  Once we don't build a dynamic library anymore, we need to explicitly link libosmogsm.so from here or we end up with missing symbols.


-- 
To view, visit https://gerrit.osmocom.org/6270
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba0a2c9c694e360356ac2ca584e97795281c6198
Gerrit-PatchSet: 2
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list