osmo-msc[master]: WIP: VTY: Add 'show connections' and 'show transactions' com...

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Feb 5 22:27:12 UTC 2018


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/#/c/6050/1//COMMIT_MSG
Commit Message:

Line 18: Related: OS#2855
> cosmetic: is it related to https://osmocom.org/issues/2855?
Done


https://gerrit.osmocom.org/#/c/6050/1/src/libmsc/vty_interface_layer3.c
File src/libmsc/vty_interface_layer3.c:

Line 120: 	default:
> What about GSM48_PDISC_USSD / GSM48_PDISC_NC_SS?
We have no state in the gsm_trans struct, so what should I print here?


-- 
To view, visit https://gerrit.osmocom.org/6050
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c457c1eac20188f67b8379a36cfda3a085fcef4
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list