[MERGED] osmo-bts[master]: octphy: octpkt.c: Remove unused static functions

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Feb 5 13:16:03 UTC 2018


Harald Welte has submitted this change and it was merged.

Change subject: octphy: octpkt.c: Remove unused static functions
......................................................................


octphy: octpkt.c: Remove unused static functions

Change-Id: I97c08b66d41ab5902a11a1e989e278c56cdee102
---
M src/osmo-bts-octphy/octpkt.c
1 file changed, 0 insertions(+), 32 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bts-octphy/octpkt.c b/src/osmo-bts-octphy/octpkt.c
index a6167f5..d96d93d 100644
--- a/src/osmo-bts-octphy/octpkt.c
+++ b/src/osmo-bts-octphy/octpkt.c
@@ -73,22 +73,6 @@
 	ch->ulSocketId = htonl(socket_id);
 }
 
-/* push a data header (3 dwords) to the start of a msgb. This format is
- * used for event packets */
-static void octvocnet_push_data_hdr(struct msgb *msg,
-				 uint32_t log_obj_hdl,
-				 uint32_t log_obj_pkt_port,
-				 uint32_t dest_fifo_id)
-{
-	tOCTVOCNET_PKT_DATA_HEADER *dh;
-
-	dh = (tOCTVOCNET_PKT_DATA_HEADER *) msgb_push(msg, sizeof(*dh));
-
-	dh->hLogicalObj = htonl(log_obj_hdl);
-	dh->ulLogicalObjPktPort = htonl(log_obj_pkt_port);
-	dh->ulDestFifoId = htonl(dest_fifo_id);
-}
-
 /* common msg_header shared by all control messages. host byte order! */
 void octvc1_fill_msg_hdr(tOCTVC1_MSG_HEADER *mh, uint32_t len,
 			uint32_t sess_id, uint32_t trans_id,
@@ -108,22 +92,6 @@
 	mh->ulSessionId = sess_id;
 	mh->ulReturnCode = 0;
 	mh->ulUserInfo = user_info;
-}
-
-static void octvc1_push_msg_hdr(struct msgb *msg,
-				uint32_t sess_id,
-				uint32_t trans_id,
-				uint32_t user_info,
-				uint32_t msg_type,
-				uint32_t flags,
-				uint32_t api_cmd)
-{
-	tOCTVC1_MSG_HEADER *mh;
-	uint32_t len = msgb_length(msg);
-
-	mh = (tOCTVC1_MSG_HEADER *) msgb_push(msg, sizeof(*mh));
-
-	octvc1_fill_msg_hdr(mh, len, sess_id, trans_id, user_info, msg_type, flags, api_cmd);
 }
 
 #include <sys/ioctl.h>

-- 
To view, visit https://gerrit.osmocom.org/6271
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I97c08b66d41ab5902a11a1e989e278c56cdee102
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list