[PATCH] osmo-pcu[master]: vty: add commands to show TBF of a certain kind

Max gerrit-no-reply at lists.osmocom.org
Thu Feb 1 17:32:28 UTC 2018


Review at  https://gerrit.osmocom.org/6239

vty: add commands to show TBF of a certain kind

Add vty commands to show only TBFs allocated via PACCH or CCCH.

Change-Id: I80f8df4fe663a0346f4289a4220b761e39726312
Related: OS#1759
---
M src/pcu_vty.c
M src/pcu_vty_functions.cpp
M src/pcu_vty_functions.h
3 files changed, 24 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/39/6239/1

diff --git a/src/pcu_vty.c b/src/pcu_vty.c
index 5c3f625..47d87f9 100644
--- a/src/pcu_vty.c
+++ b/src/pcu_vty.c
@@ -1065,7 +1065,23 @@
       SHOW_STR "information about TBFs\n" "All TBFs\n")
 {
 	struct gprs_rlcmac_bts *bts = bts_main_data();
-	return pcu_vty_show_tbf_all(vty, bts);
+	return pcu_vty_show_tbf_all(vty, bts, true, true);
+}
+
+DEFUN(show_tbf_ccch,
+      show_tbf_ccch_cmd,
+      "show tbf ccch",
+      SHOW_STR "information about TBFs\n" "TBFs allocated via CCCH\n")
+{
+	return pcu_vty_show_tbf_all(vty, bts_main_data(), true, false);
+}
+
+DEFUN(show_tbf_pacch,
+      show_tbf_pacch_cmd,
+      "show tbf pacch",
+      SHOW_STR "information about TBFs\n" "TBFs allocated via PACCH\n")
+{
+	return pcu_vty_show_tbf_all(vty, bts_main_data(), false, true);
 }
 
 DEFUN(show_ms_all,
@@ -1192,6 +1208,8 @@
 
 	install_element_ve(&show_bts_stats_cmd);
 	install_element_ve(&show_tbf_cmd);
+	install_element_ve(&show_tbf_ccch_cmd);
+	install_element_ve(&show_tbf_pacch_cmd);
 	install_element_ve(&show_ms_all_cmd);
 	install_element_ve(&show_ms_tlli_cmd);
 	install_element_ve(&show_ms_imsi_cmd);
diff --git a/src/pcu_vty_functions.cpp b/src/pcu_vty_functions.cpp
index 41165f3..6c078f2 100644
--- a/src/pcu_vty_functions.cpp
+++ b/src/pcu_vty_functions.cpp
@@ -34,7 +34,7 @@
 #include <osmocom/vty/misc.h>
 }
 
-static void tbf_print_vty_info(struct vty *vty, gprs_rlcmac_tbf *tbf)
+static void tbf_print_vty_info(struct vty *vty, gprs_rlcmac_tbf *tbf, bool show_ccch, bool show_pacch)
 {
 	gprs_rlcmac_ul_tbf *ul_tbf = as_ul_tbf(tbf);
 	gprs_rlcmac_dl_tbf *dl_tbf = as_dl_tbf(tbf);
@@ -91,18 +91,18 @@
 	vty_out(vty, "%s%s", VTY_NEWLINE, VTY_NEWLINE);
 }
 
-int pcu_vty_show_tbf_all(struct vty *vty, struct gprs_rlcmac_bts *bts_data)
+int pcu_vty_show_tbf_all(struct vty *vty, struct gprs_rlcmac_bts *bts_data, bool show_ccch, bool show_pacch)
 {
 	BTS *bts = bts_data->bts;
 	LListHead<gprs_rlcmac_tbf> *ms_iter;
 
 	vty_out(vty, "UL TBFs%s", VTY_NEWLINE);
 	llist_for_each(ms_iter, &bts->ul_tbfs())
-		tbf_print_vty_info(vty, ms_iter->entry());
+		tbf_print_vty_info(vty, ms_iter->entry(), show_ccch, show_pacch);
 
 	vty_out(vty, "%sDL TBFs%s", VTY_NEWLINE, VTY_NEWLINE);
 	llist_for_each(ms_iter, &bts->dl_tbfs())
-		tbf_print_vty_info(vty, ms_iter->entry());
+		tbf_print_vty_info(vty, ms_iter->entry(), show_ccch, show_pacch);
 
 	return CMD_SUCCESS;
 }
diff --git a/src/pcu_vty_functions.h b/src/pcu_vty_functions.h
index 470df0e..3fef208 100644
--- a/src/pcu_vty_functions.h
+++ b/src/pcu_vty_functions.h
@@ -27,7 +27,7 @@
 struct vty;
 struct gprs_rlcmac_bts;
 
-int pcu_vty_show_tbf_all(struct vty *vty, struct gprs_rlcmac_bts *bts_data);
+int pcu_vty_show_tbf_all(struct vty *vty, struct gprs_rlcmac_bts *bts_data, bool show_ccch, bool show_pacch);
 int pcu_vty_show_ms_all(struct vty *vty, struct gprs_rlcmac_bts *bts_data);
 int pcu_vty_show_ms_by_tlli(struct vty *vty, struct gprs_rlcmac_bts *bts_data,
 	uint32_t tlli);

-- 
To view, visit https://gerrit.osmocom.org/6239
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I80f8df4fe663a0346f4289a4220b761e39726312
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>


More information about the gerrit-log mailing list