[PATCH] libosmocore[master]: tests: coding_test: Fix compilation with -O0

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Thu Feb 1 11:15:52 UTC 2018

Review at  https://gerrit.osmocom.org/6235

tests: coding_test: Fix compilation with -O0

inline keyword is a hint for the compiler to inline the function, but
it's not mandatory. If no static or extern is specified, the definition
is only visible in the current unit but the identifier still has
external linkage.
When running with -O0 it seems the compiler (gcc 7.2.1) decides to use
the external linkage but at the same time it seems it's not generating
the function symbol. Fix it by explicitly stating that we want to use
static linking for this function.

coding/coding_test.o: In function `test_xcch':
libosmocore/tests/coding/coding_test.c:86: undefined reference to `dump_ubits'
libosmocore/tests/coding/coding_test.c:87: undefined reference to `dump_sbits'

Change-Id: I18018adec05ce1c2ddbca38653311d74c7454ce8
M tests/coding/coding_test.c
1 file changed, 2 insertions(+), 2 deletions(-)

  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/35/6235/1

diff --git a/tests/coding/coding_test.c b/tests/coding/coding_test.c
index 511dbb7..660f51f 100644
--- a/tests/coding/coding_test.c
+++ b/tests/coding/coding_test.c
@@ -44,7 +44,7 @@
 			return;						\
 	} while(0)
-inline void dump_ubits(ubit_t *bursts_u, unsigned until)
+static inline void dump_ubits(ubit_t *bursts_u, unsigned until)
 	DUMP_U_AT(bursts_u, 0, until);
@@ -57,7 +57,7 @@
 	DUMP_U_AT(bursts_u, 812, until);
-inline void dump_sbits(uint8_t *bursts_s, unsigned until)
+static inline void dump_sbits(uint8_t *bursts_s, unsigned until)
 	DUMP_S_AT(bursts_s, 0, until);

To view, visit https://gerrit.osmocom.org/6235
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I18018adec05ce1c2ddbca38653311d74c7454ce8
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>

More information about the gerrit-log mailing list