Change in libosmocore[master]: NS: use monotonic clock

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/5104 )

Change subject: NS: use monotonic clock
......................................................................


Patch Set 6: Code-Review-1

(3 comments)

https://gerrit.osmocom.org/#/c/5104/6/include/osmocom/gprs/gprs_ns.h
File include/osmocom/gprs/gprs_ns.h:

https://gerrit.osmocom.org/#/c/5104/6/include/osmocom/gprs/gprs_ns.h@130
PS6, Line 130: 	struct timeval timer_started; /* deprecated! will be replaced by t_start eventually */
Eventually? isn't it replaced in this same commit? this field should then be removed now.


https://gerrit.osmocom.org/#/c/5104/6/src/gb/gprs_ns.c
File src/gb/gprs_ns.c:

https://gerrit.osmocom.org/#/c/5104/6/src/gb/gprs_ns.c@615
PS6, Line 615: 	if (clock_gettime(CLOCK_MONOTONIC, &nsvc->t_start) != 0) {
osmo_clock_gettime.


https://gerrit.osmocom.org/#/c/5104/6/src/gb/gprs_ns.c@617
PS6, Line 617: 		     nsvc->nsei, get_value_string(timer_mode_strs, mode), seconds, strerror(errno));
if it says it fails, it shouldn't start the timer by calling osmo_timer_schedule, but return here before doing so.



-- 
To view, visit https://gerrit.osmocom.org/5104
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6949601a80747f0de1a05e0790a1bace209efbf
Gerrit-Change-Number: 5104
Gerrit-PatchSet: 6
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-CC: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Sun, 30 Dec 2018 23:28:36 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181230/78d5d6ba/attachment.htm>