Change in libosmocore[master]: LCLS: don't send invalid status in HO messages

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Sat Dec 29 18:59:38 UTC 2018


Max has posted comments on this change. ( https://gerrit.osmocom.org/12377 )

Change subject: LCLS: don't send invalid status in HO messages
......................................................................


Patch Set 5:

> lcls_bss_status_present is a field in a public structure, so it's part of the public API right?

Right but it's removed in https://gerrit.osmocom.org/c/libosmocore/+/12369 and not in this commit.

> If it was already present in an older release, then we should avoid changing it to prevent from API breakage. If it was included after latest release, it's fine to change it since it was never released.

If we would follow this logic we'll keep broken API forever which does not make much sense and that's not how we handled this so far. Instead we should properly bump the API/ABI version. To do that we update TODO-RELEASE which is done in corresponding commit.


-- 
To view, visit https://gerrit.osmocom.org/12377
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2dc3a2896b133298cbf850d68e6898300884bbce
Gerrit-Change-Number: 12377
Gerrit-PatchSet: 5
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name>
Gerrit-Comment-Date: Sat, 29 Dec 2018 18:59:38 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181229/3267d645/attachment.htm>


More information about the gerrit-log mailing list