Change in osmocom-bb[master]: layer23/sap_interface.c: drop meaningless call to sap_msg_free()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Dec 26 12:12:04 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12437 )

Change subject: layer23/sap_interface.c: drop meaningless call to sap_msg_free()
......................................................................


Patch Set 1: Code-Review+2

I agree with this patch.  However, I think any function called _free() should behave like libc free() and accept NULL pointers.  But that would be separate fix/patch


-- 
To view, visit https://gerrit.osmocom.org/12437
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf868c4299e292a17c4b7aad1f9e728ea3653494
Gerrit-Change-Number: 12437
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Kévin Redon <kredon at sysmocom.de>
Gerrit-Comment-Date: Wed, 26 Dec 2018 12:12:04 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181226/5107acd7/attachment.htm>


More information about the gerrit-log mailing list