Change in libosmocore[master]: utils: drop redundant _SOURCES entries

[Harald Welte]

Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12392 )

Change subject: utils: drop redundant _SOURCES entries
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/12392/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/12392/1//COMMIT_MSG@9
PS1, Line 9: Automake use the .c file corresponding to the program name
           : automatically, there's no need to use _SOURCES unless they have
           : multiple files in them.
I had no idea of this automatism.  You will probably find more MAkefile.am in Osmocom where it's stated explicitly.  On the other hand, we don't loose anything from stating it explicitly, and one can argue it's easier to add more files later on.  Hence I would (again) put this into the category "why are we [you] spending time on something like this?"



-- 
To view, visit https://gerrit.osmocom.org/12392
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0374e2d38e6bdc416eec182030af94b89d65ab7
Gerrit-Change-Number: 12392
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Sun, 23 Dec 2018 10:27:28 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181223/6a0ca8dd/attachment.htm>