This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12368 ) Change subject: abort assignment on Assignment Failure ...................................................................... Patch Set 7: (1 comment) https://gerrit.osmocom.org/#/c/12368/7/src/libmsc/msc_mgcp.c File src/libmsc/msc_mgcp.c: https://gerrit.osmocom.org/#/c/12368/7/src/libmsc/msc_mgcp.c@1097 PS7, Line 1097: int msc_mgcp_ass_fail(struct ran_conn *conn) the functions before and after this new function all have nice documentation about what they do. I would argue at least a one line dsescription of when/how it is used and the return values should be documented. -- To view, visit https://gerrit.osmocom.org/12368 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I358cfbaf0f44f25148e8b9bafcb9257b1952b35a Gerrit-Change-Number: 12368 Gerrit-PatchSet: 7 Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-CC: Harald Welte <laforge at gnumonks.org> Gerrit-Comment-Date: Sun, 23 Dec 2018 10:07:52 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181223/9d2aa84a/attachment.htm>