This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12411 ) Change subject: Reply to CHECK-IMEI GSUP messages ...................................................................... Patch Set 2: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/12411/2/src/hlr.c File src/hlr.c: https://gerrit.osmocom.org/#/c/12411/2/src/hlr.c@431 PS2, Line 431: osmo_gsup_encode > Not critical, but what if this function would fail? […] this is correct, but the style of the new code follows the style of the existing code, where the return value isn't checked either. Let's address that (if needed) in a separate patch. -- To view, visit https://gerrit.osmocom.org/12411 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib240474b0c3c603ba840cf26babb38a44dfc9364 Gerrit-Change-Number: 12411 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Comment-Date: Sat, 22 Dec 2018 20:15:42 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181222/bd5c521c/attachment.htm>