Change in libosmocore[master]: GSUP: fix missing osmo_gsup_get_err_msg_type()s

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Fri Dec 21 11:56:23 UTC 2018


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12408 )

Change subject: GSUP: fix missing osmo_gsup_get_err_msg_type()s
......................................................................


Patch Set 1:

I don't think we can merely remove this function, because this is a library API.
We can either a) call the macro from it, or b) remove it and add an alias:

  #define osmo_gsup_get_err_msg_type(t) \
    OSMO_GSUP_TO_MSGT_ERROR(t)

Let's wait for Harald's response.


-- 
To view, visit https://gerrit.osmocom.org/12408
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I801a0d6ffe09cfc75b77ab602bd25b3dc40f19c0
Gerrit-Change-Number: 12408
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Fri, 21 Dec 2018 11:56:23 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181221/6c90acfc/attachment.htm>


More information about the gerrit-log mailing list