This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
osmith gerrit-no-reply at lists.osmocom.orgosmith has posted comments on this change. ( https://gerrit.osmocom.org/12408 ) Change subject: GSUP: fix missing osmo_gsup_get_err_msg_type()s ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/12408/1/src/gsm/gsup.c File src/gsm/gsup.c: https://gerrit.osmocom.org/#/c/12408/1/src/gsm/gsup.c@96 PS1, Line 96: osmo_gsup_get_err_msg_type > Hmm, do we really need this function? There is a macro: […] I would also prefer the macro, so the function does not need to be adjusted every time. Maybe we can remove the function altogether and use the macro everywhere instead? Harald added the function here, at which time the macro was already present: https://gerrit.osmocom.org/#/c/libosmocore/+/9549/ Maybe he can comment on why that was done. -- To view, visit https://gerrit.osmocom.org/12408 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I801a0d6ffe09cfc75b77ab602bd25b3dc40f19c0 Gerrit-Change-Number: 12408 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Comment-Date: Fri, 21 Dec 2018 11:44:57 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181221/cce2cffc/attachment.htm>