This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Vadim Yanitskiy gerrit-no-reply at lists.osmocom.orgVadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12408 ) Change subject: GSUP: fix missing osmo_gsup_get_err_msg_type()s ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Looks good, but please see my comments. I didn't update this function intentionally. Let's decide, de we really need to duplicate? https://gerrit.osmocom.org/#/c/12408/1/src/gsm/gsup.c File src/gsm/gsup.c: https://gerrit.osmocom.org/#/c/12408/1/src/gsm/gsup.c@96 PS1, Line 96: osmo_gsup_get_err_msg_type Hmm, do we really need this function? There is a macro: OSMO_GSUP_TO_MSGT_ERROR(msgt) which does exactly the same. -- To view, visit https://gerrit.osmocom.org/12408 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I801a0d6ffe09cfc75b77ab602bd25b3dc40f19c0 Gerrit-Change-Number: 12408 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Comment-Date: Fri, 21 Dec 2018 11:34:26 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181221/c155cb68/attachment.htm>