Change in gr-gsm[master]: trx/txtime_setter: print error if reference fn is missing

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Thu Dec 20 23:56:10 UTC 2018


Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/12395


Change subject: trx/txtime_setter: print error if reference fn is missing
......................................................................

trx/txtime_setter: print error if reference fn is missing

Change-Id: I2a6e3f41b6fe79b92d85ff98bc2cd9afd9bdc568
---
M lib/transmitter/txtime_setter_impl.cc
1 file changed, 7 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/gr-gsm refs/changes/95/12395/1

diff --git a/lib/transmitter/txtime_setter_impl.cc b/lib/transmitter/txtime_setter_impl.cc
index 50092f4..9f3a24d 100644
--- a/lib/transmitter/txtime_setter_impl.cc
+++ b/lib/transmitter/txtime_setter_impl.cc
@@ -116,9 +116,6 @@
 
     void txtime_setter_impl::process_txtime_of_burst(pmt::pmt_t msg_in)
     {
-      if (d_fn_ref == UNKNOWN_FN)
-        return;
-
       pmt::pmt_t blob = pmt::cdr(msg_in);
 
       // Extract GSMTAP header from message
@@ -126,6 +123,13 @@
       uint32_t frame_nr = be32toh(header->frame_number);
       uint32_t ts_num = header->timeslot;
 
+      if (d_fn_ref == UNKNOWN_FN) {
+        std::cout << "Missing reference TDMA frame number, dropping "
+                  << format("burst (fn=%u, tn=%u)", frame_nr, ts_num)
+                  << std::endl;
+        return;
+      }
+
       time_format txtime = fn_time_delta_cpp(d_fn_ref, d_time_ref,
         frame_nr, d_time_hint, ts_num, d_ts_ref);
 

-- 
To view, visit https://gerrit.osmocom.org/12395
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: gr-gsm
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2a6e3f41b6fe79b92d85ff98bc2cd9afd9bdc568
Gerrit-Change-Number: 12395
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181220/ffdc23b8/attachment.htm>


More information about the gerrit-log mailing list