This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Stefan Sperling gerrit-no-reply at lists.osmocom.orgStefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11920 ) Change subject: libmsc/gsm_04_11.c: accept MT SMS messages over GSUP ...................................................................... Patch Set 8: (3 comments) https://gerrit.osmocom.org/#/c/11920/8/src/libmsc/gsm_04_11.c File src/libmsc/gsm_04_11.c: https://gerrit.osmocom.org/#/c/11920/8/src/libmsc/gsm_04_11.c@802 PS8, Line 802: goto sms_over_gsup; Could put this right here on this line: return gsm411_gsup_mt_fwd_sm_res(trans, rph->msg_ref); Instead of using 'goto'. https://gerrit.osmocom.org/#/c/11920/8/src/libmsc/gsm_04_11.c@825 PS8, Line 825: return gsm411_gsup_mt_fwd_sm_res(trans, rph->msg_ref); And then we could remove this part. https://gerrit.osmocom.org/#/c/11920/8/src/libmsc/gsm_04_11.c@845 PS8, Line 845: goto sms_over_gsup; Same here, just use the patern if (..) return foo(); -- To view, visit https://gerrit.osmocom.org/11920 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57357982ca0e51f6722c24a4aa1d0fb3e6caef88 Gerrit-Change-Number: 11920 Gerrit-PatchSet: 8 Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Stefan Sperling <stsp at stsp.name> Gerrit-Comment-Date: Thu, 20 Dec 2018 11:35:22 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181220/ae1dd327/attachment.htm>