This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12375 ) Change subject: LCLS: don't encode incorrect values ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/12375/1/src/gsm/gsm0808.c File src/gsm/gsm0808.c: https://gerrit.osmocom.org/#/c/12375/1/src/gsm/gsm0808.c@340 PS1, Line 340: if (status == GSM0808_LCLS_STS_NA) I'm not sure this is worth it. The value can be *any* integer in most C compilers (particularly, gcc), and you are now checking for one invalid value, but not for close to 2^32 to 2^64 other invalid values... -- To view, visit https://gerrit.osmocom.org/12375 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ac4bae75f5796e6e11346b8cb34d3897ae70b59 Gerrit-Change-Number: 12375 Gerrit-PatchSet: 1 Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Harald Welte <laforge at gnumonks.org> Gerrit-Comment-Date: Wed, 19 Dec 2018 20:53:14 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181219/d4b966a5/attachment.htm>