Change in libosmocore[master]: LCLS: drop boolean status_present from HO structs

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Wed Dec 19 18:56:58 UTC 2018


Max has uploaded this change for review. ( https://gerrit.osmocom.org/12377


Change subject: LCLS: drop boolean status_present from HO structs
......................................................................

LCLS: drop boolean status_present from HO structs

The validity of lcls_bss_status can be determined from the value itself
so we don't need those parameters in the struct.

Change-Id: I2dc3a2896b133298cbf850d68e6898300884bbce
---
M TODO-RELEASE
M include/osmocom/gsm/gsm0808.h
2 files changed, 1 insertion(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/77/12377/1

diff --git a/TODO-RELEASE b/TODO-RELEASE
index 16d96ec..f6ec3ab 100644
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -19,3 +19,4 @@
 libosmogsm	osmo_gsup_message			extended with SMS related fields
 libosmogsm	osmo_gsup_sms_{en|de}code_sm_rp_da	GSUP SM-RP-DA coding helpers
 libosmogsm	osmo_gsup_sms_{en|de}code_sm_rp_oa	GSUP SM-RP-OA coding helpers
+libosmogsm	struct gsm0808_handover_complete	Remove unnecessary boolean parameters
\ No newline at end of file
diff --git a/include/osmocom/gsm/gsm0808.h b/include/osmocom/gsm/gsm0808.h
index 79d89e5..ccecda4 100644
--- a/include/osmocom/gsm/gsm0808.h
+++ b/include/osmocom/gsm/gsm0808.h
@@ -157,7 +157,6 @@
 	bool chosen_channel_present;
 	uint8_t chosen_channel;
 
-	bool lcls_bss_status_present;
 	enum gsm0808_lcls_status lcls_bss_status;
 
 	/* more items are defined in the spec and may be added later */
@@ -194,7 +193,6 @@
 	bool speech_codec_chosen_present;
 	struct gsm0808_speech_codec speech_codec_chosen;
 
-	bool lcls_bss_status_present;
 	enum gsm0808_lcls_status lcls_bss_status;
 
 	/* more items are defined in the spec and may be added later */

-- 
To view, visit https://gerrit.osmocom.org/12377
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2dc3a2896b133298cbf850d68e6898300884bbce
Gerrit-Change-Number: 12377
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181219/e713481e/attachment.htm>


More information about the gerrit-log mailing list