This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgNeels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/12356 ) Change subject: osmo-mgw: err-log: include expected domain name ...................................................................... osmo-mgw: err-log: include expected domain name Add the expected domain name, and move the error log to where the expected domain name is compared. Change-Id: I59f40dc9263f686852f103ca904fc0a6702d7c8e --- M src/libosmo-mgcp/mgcp_msg.c 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified Pau Espin Pedrol: Looks good to me, approved diff --git a/src/libosmo-mgcp/mgcp_msg.c b/src/libosmo-mgcp/mgcp_msg.c index 648d86b..f98b9ee 100644 --- a/src/libosmo-mgcp/mgcp_msg.c +++ b/src/libosmo-mgcp/mgcp_msg.c @@ -223,8 +223,10 @@ if (!strcmp(cfg->domain, "*")) return 0; - if (strcmp(domain_to_check+1, cfg->domain) != 0) + if (strcmp(domain_to_check+1, cfg->domain) != 0) { + LOGP(DLMGCP, LOGL_ERROR, "Wrong domain name '%s', expecting '%s'\n", mgcp, cfg->domain); return -EINVAL; + } return 0; } @@ -244,7 +246,6 @@ /* Check if the domainname in the request is correct */ if (check_domain_name(cfg, mgcp)) { - LOGP(DLMGCP, LOGL_ERROR, "Wrong domain name '%s'\n", mgcp); *cause = -500; return NULL; } -- To view, visit https://gerrit.osmocom.org/12356 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I59f40dc9263f686852f103ca904fc0a6702d7c8e Gerrit-Change-Number: 12356 Gerrit-PatchSet: 2 Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181219/5576cb19/attachment.htm>