This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgNeels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12270 ) Change subject: mgcp_client: logging tweaks ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/12270/1/src/libosmo-mgcp-client/mgcp_client.c File src/libosmo-mgcp-client/mgcp_client.c: https://gerrit.osmocom.org/#/c/12270/1/src/libosmo-mgcp-client/mgcp_client.c@851 PS1, Line 851: LOGP(DLMGCP, LOGL_INFO, "MGCP GW connection: %s\n", osmo_sock_get_name2(wq->bfd.fd)); > Why issuing a syscall if we already have the information stored in a struct? yeah, true, but it is just one single syscall at program startup, once for the entire osmo-bsc/osmo-msc lifetime. The benefit: use the same formatting as other logging does, and no mistakes possible from string juggling. -- To view, visit https://gerrit.osmocom.org/12270 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iae728192f499330d16836d9435648f6b8ed213b6 Gerrit-Change-Number: 12270 Gerrit-PatchSet: 2 Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Comment-Date: Wed, 19 Dec 2018 16:50:56 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181219/420f6d47/attachment.htm>