This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgHello dexter, Max, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12354 to look at the new patch set (#2). Change subject: mgcp_client: drop a bunch of dead code ...................................................................... mgcp_client: drop a bunch of dead code Remove public API that makes no sense anymore and is dead code. I see the dropped API as a dead-end initial misconception of the early mgcp client, and it doesn't really make sense to drag this stuff along. It has not been used by osmo-msc,-bsc for a long time now, and just confuses the reader. It is public API, yes, and older versions of osmo-msc / osmo-bsc will not be able to compile against this, but even if it did, the resulting MGCP client would not work with the current osmo-mgw: this API is still based on the premise that the MGCP client dictates the MGW endpoint numbers, a concept that cannot be used with the current osmo-mgw. Instead, osmo-mgw expects a wildcarded endpoint upon CRCX and assigns its own endpoint names. Also, the bts-base configuration is unused and a legacy of when osmo-bsc_mgcp had explicit BTS and CN sides. Change-Id: I98a9f1f17a1c4ab20cea3b08c7d21663592134d6 --- M TODO-RELEASE M include/osmocom/mgcp_client/mgcp_client.h M src/libosmo-mgcp-client/mgcp_client.c M src/libosmo-mgcp-client/mgcp_client_vty.c M tests/mgcp_client/mgcp_client_test.c M tests/mgcp_client/mgcp_client_test.err M tests/mgcp_client/mgcp_client_test.ok 7 files changed, 12 insertions(+), 415 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/54/12354/2 -- To view, visit https://gerrit.osmocom.org/12354 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I98a9f1f17a1c4ab20cea3b08c7d21663592134d6 Gerrit-Change-Number: 12354 Gerrit-PatchSet: 2 Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181219/e75a3229/attachment.htm>