This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Max gerrit-no-reply at lists.osmocom.orgMax has uploaded this change for review. ( https://gerrit.osmocom.org/12369 Change subject: LCLS: don't send invalid status in HO messages ...................................................................... LCLS: don't send invalid status in HO messages Change-Id: Ib2958a8613627c4e54c004ffa3578c300ed0360b --- M include/osmocom/gsm/gsm0808.h M src/gsm/gsm0808.c 2 files changed, 2 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/69/12369/1 diff --git a/include/osmocom/gsm/gsm0808.h b/include/osmocom/gsm/gsm0808.h index 79d89e5..ccecda4 100644 --- a/include/osmocom/gsm/gsm0808.h +++ b/include/osmocom/gsm/gsm0808.h @@ -157,7 +157,6 @@ bool chosen_channel_present; uint8_t chosen_channel; - bool lcls_bss_status_present; enum gsm0808_lcls_status lcls_bss_status; /* more items are defined in the spec and may be added later */ @@ -194,7 +193,6 @@ bool speech_codec_chosen_present; struct gsm0808_speech_codec speech_codec_chosen; - bool lcls_bss_status_present; enum gsm0808_lcls_status lcls_bss_status; /* more items are defined in the spec and may be added later */ diff --git a/src/gsm/gsm0808.c b/src/gsm/gsm0808.c index 69da57d..192c0be 100644 --- a/src/gsm/gsm0808.c +++ b/src/gsm/gsm0808.c @@ -898,7 +898,7 @@ msgb_tv_put(msg, GSM0808_IE_CHOSEN_ENCR_ALG, params->chosen_encr_alg); /* LCLS-BSS-Status 3.2.2.119 */ - if (params->lcls_bss_status_present) + if (params->lcls_bss_status != GSM0808_LCLS_STS_NA) msgb_tv_put(msg, GSM0808_IE_LCLS_BSS_STATUS, params->lcls_bss_status); /* prepend header with final length */ @@ -974,7 +974,7 @@ gsm0808_enc_speech_codec(msg, ¶ms->speech_codec_chosen); /* LCLS-BSS-Status 3.2.2.119 */ - if (params->lcls_bss_status_present) + if (params->lcls_bss_status != GSM0808_LCLS_STS_NA) msgb_tv_put(msg, GSM0808_IE_LCLS_BSS_STATUS, params->lcls_bss_status); /* prepend header with final length */ -- To view, visit https://gerrit.osmocom.org/12369 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib2958a8613627c4e54c004ffa3578c300ed0360b Gerrit-Change-Number: 12369 Gerrit-PatchSet: 1 Gerrit-Owner: Max <msuraev at sysmocom.de> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181219/69583963/attachment.htm>