Change in osmo-bts[master]: sysmobts_mgr: Prepare code for gpsd < 2.96 support

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Dec 18 13:52:12 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12339 )

Change subject: sysmobts_mgr: Prepare code for gpsd < 2.96 support
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/12339/1/src/osmo-bts-sysmo/misc/sysmobts_mgr_calib.c
File src/osmo-bts-sysmo/misc/sysmobts_mgr_calib.c:

https://gerrit.osmocom.org/#/c/12339/1/src/osmo-bts-sysmo/misc/sysmobts_mgr_calib.c@145
PS1, Line 145: 
here should be
  
  gpsdata = &gpsdata_buf

or this would be a segfault, right?



-- 
To view, visit https://gerrit.osmocom.org/12339
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaeb5ac527cc3e58168027021d0f60afa93d1fb6f
Gerrit-Change-Number: 12339
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Tue, 18 Dec 2018 13:52:12 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181218/e735f59b/attachment.htm>


More information about the gerrit-log mailing list