This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgNeels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12268 ) Change subject: add to osmo_sock_get_name*() API ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/12268/1/include/osmocom/core/socket.h File include/osmocom/core/socket.h: https://gerrit.osmocom.org/#/c/12268/1/include/osmocom/core/socket.h@64 PS1, Line 64: int osmo_sock_get_name_buf(char *str, size_t str_len, int fd); > I mean it should be named osmo_sock_get_name_buf(). […] ok. Just to make sure, it's not confusing that osmo_sock_get_name_buf() results in "r:1.2.3.4:5<->l:4.5.6.7:8" while osmo_sock_get_name() returns a tallocd "(r:....7:8)" with braces? (I will know this, but am worried about future readers) If you're sure then I'll drop the 2. https://gerrit.osmocom.org/#/c/12268/1/src/socket.c File src/socket.c: https://gerrit.osmocom.org/#/c/12268/1/src/socket.c@796 PS1, Line 796: * \param[out] str Destination string buffer. > Well since a variable in C cannot contain a space, it makes no sense to me to add an extra space, it […] lol what, a variable containing a space? I do this just for readability, I find it a lot easier to spot where the doc string starts when setting it apart from the variable name. I'd even use a tab if I liked tabs. Would a tab be better? -- To view, visit https://gerrit.osmocom.org/12268 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8ad89ac447c9c582742e70d082072bdd40a5a398 Gerrit-Change-Number: 12268 Gerrit-PatchSet: 2 Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 18 Dec 2018 02:49:17 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181218/b3d352ed/attachment.htm>