This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Vadim Yanitskiy gerrit-no-reply at lists.osmocom.orgVadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12321 ) Change subject: vty: Introduce telnet_init_default and make vty port configurable ...................................................................... Patch Set 1: Code-Review-1 (4 comments) I still would like to see a better commit description. BTW: I don't think 'int' vs 'unsigned' is critical. TODO: let's replace s/UDP/TCP/ in a separate change! https://gerrit.osmocom.org/#/c/12321/1/src/vty/telnet_interface.c File src/vty/telnet_interface.c: https://gerrit.osmocom.org/#/c/12321/1/src/vty/telnet_interface.c@70 PS1, Line 70: port UDP port number I think it was copy-pasted from here... https://gerrit.osmocom.org/#/c/12321/1/src/vty/telnet_interface.c@81 PS1, Line 81: port UDP port number or here ;) https://gerrit.osmocom.org/#/c/12321/1/src/vty/telnet_interface.c@111 PS1, Line 111: if not explicitely configured > "if not explicitely configured" ... from where? Let's clarify that VTY parameters do overwrite this 'default' port. BTW: typo: explicitely -> explicitly https://gerrit.osmocom.org/#/c/12321/1/src/vty/telnet_interface.c@111 PS1, Line 111: * \param[in] default_port UDP port number to use if not explicitely configured > UDP? Doesn't telnet/VTY run over TCP in this universe? Agree, should be TCP. -- To view, visit https://gerrit.osmocom.org/12321 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id5fb2faaf4311bd7284ee870526a6f87b7e260f3 Gerrit-Change-Number: 12321 Gerrit-PatchSet: 1 Gerrit-Owner: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name> Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Comment-Date: Mon, 17 Dec 2018 23:59:58 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181217/8b600d56/attachment.htm>