This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgNeels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12243 )
Change subject: make gsup ipa name configurable in osmo-sgsn.cfg
......................................................................
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/12243/3/src/gprs/sgsn_vty.c
File src/gprs/sgsn_vty.c:
https://gerrit.osmocom.org/#/c/12243/3/src/gprs/sgsn_vty.c@1195
PS3, Line 1195: if (!parsing_config_file) {
> OK, so say the user changes the ipa-name. And now we print a warning that they did something bad. […]
my question: do things break when changing during run-time?
If they break, then rejecting is justified and explain why in a comment or the vty out message.
Do things not break, and simply have no effect?
Then that is how many other vty options already work, and matches the feeling that we're editing cached config that doesn't necessarily have an effect on the running program. It matches the current scheme, and that can be allowed.
For example in osmo-bsc you can edit the pchan settings of time slots, and you can write them back to config file, but they will only have an effect when you re-connect the OML. Re-connect OML can be done by 'do bts 0 drop oml' or something, or a program restart.
(...still valid: just use vty->type)
--
To view, visit https://gerrit.osmocom.org/12243
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f65fed9f56b9718e8a9647e3f01dce69870c1f
Gerrit-Change-Number: 12243
Gerrit-PatchSet: 3
Gerrit-Owner: Stefan Sperling <stsp at stsp.name>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name>
Gerrit-Comment-Date: Mon, 17 Dec 2018 19:39:54 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181217/bf2426fb/attachment.htm>