Change in osmo-sgsn[master]: make gsup ipa name configurable in osmo-sgsn.cfg

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Mon Dec 17 16:18:57 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12243 )

Change subject: make gsup ipa name configurable in osmo-sgsn.cfg
......................................................................


Patch Set 3:

> 
 > I really don't see why a regular user would want to clear the name,
 > write the config, and then configure the name again to prevent the
 > network from falling apart:
 > 
 > no ipa-name
 > write file
 > ipa-name 'SGSN-911-123456879'

Why this third ipa-name? The scenario I describe is I want to revert to default, I don't need to know which is it. Does this ipa-name really need to match the same token in another node? If that's the case for HLR, then I get your point and we can skip adding it since then in prod networks it will always be set to something specific.

 > 
 > Just to save the effort of removing one line from the saved file?

I'd say one of the main points of using a VTY is that you don't ever need to modify the file directly. You may have access to the VTY but not the cfg file.

 > 
 > Considering that multi-SGSN and multi-MSC setups will be an
 > exception rather than the norm, how often do you think users will
 > even run into this?
 > Do you have a concrete situation where you would use this yourself?

If I followed this logic when implementing stuff I'll be laying on the sofa right now :P

 > Or are you arguing based on "consistency is good" (which it isn't
 > in this case, I would say)?

consistency is good. Being able to modify the value back to default without touching the cfg file is also good.


-- 
To view, visit https://gerrit.osmocom.org/12243
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f65fed9f56b9718e8a9647e3f01dce69870c1f
Gerrit-Change-Number: 12243
Gerrit-PatchSet: 3
Gerrit-Owner: Stefan Sperling <stsp at stsp.name>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name>
Gerrit-Comment-Date: Mon, 17 Dec 2018 16:18:57 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181217/a01b6da3/attachment.htm>


More information about the gerrit-log mailing list