This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgNeels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12243 )
Change subject: make gsup ipa name configurable in osmo-sgsn.cfg
......................................................................
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/12243/3/src/gprs/sgsn_vty.c
File src/gprs/sgsn_vty.c:
https://gerrit.osmocom.org/#/c/12243/3/src/gprs/sgsn_vty.c@1195
PS3, Line 1195: if (!parsing_config_file) {
instead you can do
if (vty->type != VTY_FILE)
A comment should explain why this is necessary. We have other commands that allow changing the value and write back the config, even though they have no immediate effect on the running program. I think it's good to print a warning, but do you really need to forbid tweaking the config?
--
To view, visit https://gerrit.osmocom.org/12243
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f65fed9f56b9718e8a9647e3f01dce69870c1f
Gerrit-Change-Number: 12243
Gerrit-PatchSet: 3
Gerrit-Owner: Stefan Sperling <stsp at stsp.name>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name>
Gerrit-Comment-Date: Mon, 17 Dec 2018 15:09:42 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181217/33c55b4f/attachment.htm>