Change in osmo-msc[master]: vty: show subscriber: put() before printing the use count

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Dec 17 13:25:21 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12266 )

Change subject: vty: show subscriber: put() before printing the use count
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/12266/1/src/libmsc/msc_vty.c
File src/libmsc/msc_vty.c:

https://gerrit.osmocom.org/#/c/12266/1/src/libmsc/msc_vty.c@821
PS1, Line 821: 						       argv[1]);
> If this taints the count than what about all other calls to get_vsub_by_argv()?
The other code paths don't print the use count on vty_out().
This is only about what use count the user sees.
Especially if 'show subscriber cache' and 'show subscriber msisdn 123' show different use counts, it makes you think something is broken.


https://gerrit.osmocom.org/#/c/12266/1/src/libmsc/msc_vty.c@830
PS1, Line 830: 	 * and since it existed before we called _get() on it above. */
> Are you referring to get_vsub_by_argv()? Better use function name - it's more likely to persist than […]
obviously vlr_subscr_put(), but you're right



-- 
To view, visit https://gerrit.osmocom.org/12266
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id02b57b7ed299b010b9f8b9e809548eb1e6aa699
Gerrit-Change-Number: 12266
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-CC: Max <msuraev at sysmocom.de>
Gerrit-Comment-Date: Mon, 17 Dec 2018 13:25:21 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181217/8fc43b3f/attachment.htm>


More information about the gerrit-log mailing list