Change in osmocom-bb[master]: trx_toolkit/burst_send.py: fix: use proper argparse group

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Dec 17 07:02:58 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12323 )

Change subject: trx_toolkit/burst_send.py: fix: use proper argparse group
......................................................................

trx_toolkit/burst_send.py: fix: use proper argparse group

Found using Flake8, F841 "local variable 'pf_group' is assigned
to but never used". The filtering related options should be
defined in 'pf_group' group, not in 'cnt_group'.

Change-Id: I15d17c134cbbbd54d761113a56c1f83910ab6407
---
M src/target/trx_toolkit/burst_send.py
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, approved



diff --git a/src/target/trx_toolkit/burst_send.py b/src/target/trx_toolkit/burst_send.py
index 0cf63bb..7186863 100755
--- a/src/target/trx_toolkit/burst_send.py
+++ b/src/target/trx_toolkit/burst_send.py
@@ -134,13 +134,13 @@
 			help = "Stop after sending N messages")
 
 		pf_group = parser.add_argument_group("Filtering (optional)")
-		cnt_group.add_argument("--timeslot", metavar = "TN",
+		pf_group.add_argument("--timeslot", metavar = "TN",
 			dest = "pf_tn", type = int, choices = range(0, 8),
 			help = "TDMA timeslot number (equal TN)")
-		cnt_group.add_argument("--frame-num-lt", metavar = "FN",
+		pf_group.add_argument("--frame-num-lt", metavar = "FN",
 			dest = "pf_fn_lt", type = int,
 			help = "TDMA frame number (lower than FN)")
-		cnt_group.add_argument("--frame-num-gt", metavar = "FN",
+		pf_group.add_argument("--frame-num-gt", metavar = "FN",
 			dest = "pf_fn_gt", type = int,
 			help = "TDMA frame number (greater than FN)")
 

-- 
To view, visit https://gerrit.osmocom.org/12323
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I15d17c134cbbbd54d761113a56c1f83910ab6407
Gerrit-Change-Number: 12323
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181217/566e9c7c/attachment.htm>


More information about the gerrit-log mailing list