Change in osmo-sysmon[master]: ctrl: log host/port on errors

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Dec 14 15:17:16 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12318 )

Change subject: ctrl: log host/port on errors
......................................................................


Patch Set 1: Code-Review-1

I feel this entire patchset breaks layering.  The simple_ctrl_client doesnt have a configuration. the configuration is part of the main program. but now you're passing the configuration around everywhere, adding additional arguments to the functions, making them introspect somethin that's not theirs.


-- 
To view, visit https://gerrit.osmocom.org/12318
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I788d51359965a66c54075a3971aa7824c3bfb0bf
Gerrit-Change-Number: 12318
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Comment-Date: Fri, 14 Dec 2018 15:17:16 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181214/6defbeab/attachment.htm>


More information about the gerrit-log mailing list