Change in osmo-gsm-manuals[master]: chapters/gsup.adoc: document MO-/MT-forwardSM messages

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Fri Dec 14 13:15:44 UTC 2018


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11836 )

Change subject: chapters/gsup.adoc: document MO-/MT-forwardSM messages
......................................................................


Patch Set 5:

(9 comments)

https://gerrit.osmocom.org/#/c/11836/4/common/chapters/gsup.adoc
File common/chapters/gsup.adoc:

https://gerrit.osmocom.org/#/c/11836/4/common/chapters/gsup.adoc@509
PS4, Line 509: Direction: MSC / SGSN => SMSC (via HLR)
> (a nicer term is "via", not "through" ... […]
Done


https://gerrit.osmocom.org/#/c/11836/4/common/chapters/gsup.adoc@541
PS4, Line 541: MO short message delivery. The corresponding MAP service is
> I still think it is really irritating to explain the same abbreviations over and over. […]
Done


https://gerrit.osmocom.org/#/c/11836/4/common/chapters/gsup.adoc@578
PS4, Line 578: see 3GPP TS 29.002, section 12.9.
> MT from glossary
Done


https://gerrit.osmocom.org/#/c/11836/4/common/chapters/gsup.adoc@579
PS4, Line 579: 
> and I still don't like this. […]
Done


https://gerrit.osmocom.org/#/c/11836/4/common/chapters/gsup.adoc@1122
PS4, Line 1122: |===
> I don't like the "nested" in here. See https://gerrit.osmocom. […]
Done


https://gerrit.osmocom.org/#/c/11836/4/common/chapters/gsup.adoc@1139
PS4, Line 1139: |===
> "Special"? What does it mean? If it has no meaning, does it even need encoding? Keep apart the inner […]
Done


https://gerrit.osmocom.org/#/c/11836/4/common/chapters/gsup.adoc@1143
PS4, Line 1143: 
> This is also "Special"? Rather just say what it means, or that it is reserved for purpose X = must n […]
Done


https://gerrit.osmocom.org/#/c/11836/5/common/chapters/gsup.adoc
File common/chapters/gsup.adoc:

https://gerrit.osmocom.org/#/c/11836/5/common/chapters/gsup.adoc@1093
PS5, Line 1093: relay sub-layer protocol. It can be either of the following:
> "Either" implies that there are only two options.

"Either" is used in the specs., see 7.6.8.1. I'll change anyway.


https://gerrit.osmocom.org/#/c/11836/5/common/chapters/gsup.adoc@1168
PS5, Line 1168: should keep RAN the connection open. See 3GPP TS 29.002, section 7.6.8.7.
> I'm having trouble understanding this part: […]
You're right. Thanks.



-- 
To view, visit https://gerrit.osmocom.org/11836
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0150756c33c1352bc4eb49421824542c711175c
Gerrit-Change-Number: 11836
Gerrit-PatchSet: 5
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-CC: Stefan Sperling <stsp at stsp.name>
Gerrit-Comment-Date: Fri, 14 Dec 2018 13:15:44 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181214/bda48b09/attachment.htm>


More information about the gerrit-log mailing list