Change in libosmocore[master]: GSUP/SMS: introduce READY-FOR-SM message

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Stefan Sperling gerrit-no-reply at lists.osmocom.org
Fri Dec 14 12:32:51 UTC 2018


Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11751 )

Change subject: GSUP/SMS: introduce READY-FOR-SM message
......................................................................


Patch Set 6: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/11751/6/src/gsm/gsup.c
File src/gsm/gsup.c:

https://gerrit.osmocom.org/#/c/11751/6/src/gsm/gsup.c@710
PS6, Line 710: 	if ((u8 = gsup_msg->sm_alert_rsn)) {
This check for non-zero means OSMO_GSUP_SMS_SM_ALERT_RSN_NONE won't ever be sent.
I assume this is intended, and ALERT_RSN_NONE is never part of a valid wire-protocol message?



-- 
To view, visit https://gerrit.osmocom.org/11751
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic37f3b2114b8095cfce22977e67133b9103942e3
Gerrit-Change-Number: 11751
Gerrit-PatchSet: 6
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Fri, 14 Dec 2018 12:32:51 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181214/6127b003/attachment.htm>


More information about the gerrit-log mailing list