Change in osmo-ttcn3-hacks[master]: MSC_Tests: add test to try two LU from different BSCs

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Dec 13 14:07:21 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9204 )

Change subject: MSC_Tests: add test to try two LU from different BSCs
......................................................................


Patch Set 5:

(2 comments)

https://gerrit.osmocom.org/#/c/9204/5/library/BSSMAP_Emulation.ttcn
File library/BSSMAP_Emulation.ttcn:

https://gerrit.osmocom.org/#/c/9204/5/library/BSSMAP_Emulation.ttcn@54
PS5, Line 54: 	port BSSMAPEM_PROC_PT BSSAP_PROC_1;
> I think with BTS we have an array of them? Is that possible with component ports? (arrays potentiall […]
unfortunately ports are separate concepts/objects in TTCN-3 from data types.  Only variables can form lists or arrays, but not ports :(

In terms of naming I would personally request to use BSSAP1/BSSAP_PROC1 without underscore as this resembles how we handle it in other situations, like e.g. RSL_Emulation.ttcn with RSL/RSL1 and RSL_PROC/RSL_PROC1.


https://gerrit.osmocom.org/#/c/9204/5/msc/BSC_ConnectionHandler.ttcn
File msc/BSC_ConnectionHandler.ttcn:

https://gerrit.osmocom.org/#/c/9204/5/msc/BSC_ConnectionHandler.ttcn@53
PS5, Line 53: type record of BSC_ConnHdlrBscPars BSC_ConnHdlrBscParsTable;
> ah, there's an array of BSCs here
yes, because the BSC_ConnHdlrBscPars is a data type, of which you can form records/sets/lists/arrays.  Ports however are separate objects that are declared in the component.



-- 
To view, visit https://gerrit.osmocom.org/9204
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3eabf8537066f43faed8fb983d9e1f4092ec515
Gerrit-Change-Number: 9204
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Thu, 13 Dec 2018 14:07:21 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181213/7ae2bb71/attachment.htm>


More information about the gerrit-log mailing list