Change in osmocom-bb[master]: trx_toolkit/ctrl_if_trx.py: drop meaningless warnings

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Thu Dec 13 02:53:47 UTC 2018


Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/12291


Change subject: trx_toolkit/ctrl_if_trx.py: drop meaningless warnings
......................................................................

trx_toolkit/ctrl_if_trx.py: drop meaningless warnings

A timeslot can be reconfigured at runtime, this is normal.
We should neither complain nor reject such commands.

Change-Id: I0a69ebceed5aa724093e6d1b23faad8c16705055
---
M src/target/trx_toolkit/ctrl_if_trx.py
1 file changed, 0 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/91/12291/1

diff --git a/src/target/trx_toolkit/ctrl_if_trx.py b/src/target/trx_toolkit/ctrl_if_trx.py
index b9fa751..5b2332b 100644
--- a/src/target/trx_toolkit/ctrl_if_trx.py
+++ b/src/target/trx_toolkit/ctrl_if_trx.py
@@ -120,18 +120,10 @@
 				# Deactivate TS (remove from the list of active timeslots)
 				if ts in self.trx.ts_list:
 					self.trx.ts_list.remove(ts)
-				else:
-					log.warning("TS %u was not activated before" % ts)
-					# TODO: uncomment as soon as RESET is introduced
-					# return -1
 			else:
 				# Activate TS (add to the list of active timeslots)
 				if ts not in self.trx.ts_list:
 					self.trx.ts_list.append(ts)
-				else:
-					log.warning("TS %u was already activated before" % ts)
-					# TODO: uncomment as soon as RESET is introduced
-					# return -1
 
 			return 0
 

-- 
To view, visit https://gerrit.osmocom.org/12291
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a69ebceed5aa724093e6d1b23faad8c16705055
Gerrit-Change-Number: 12291
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181213/63bef08e/attachment.htm>


More information about the gerrit-log mailing list