Change in libosmocore[master]: Use msgb helper instead of local #define for debug print

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Wed Dec 12 16:20:09 UTC 2018


Max has posted comments on this change. ( https://gerrit.osmocom.org/12271 )

Change subject: Use msgb helper instead of local #define for debug print
......................................................................


Patch Set 1:

> Patch Set 1:
> I know you wanted to split them based on spatch

Exactly.

> but this way adds extra verbosity to history and makes it more difficult to revert for no good reason.

I don't think it's actually a problem: reverting 2 patches would be 2 clicks instead of 1 (and we rarely have to do this anyway). I think keeping manual changes separated from automated code editing is worth it.


-- 
To view, visit https://gerrit.osmocom.org/12271
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6be778236eff8f2153f3113f9379ecfbec9052b
Gerrit-Change-Number: 12271
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 12 Dec 2018 16:20:09 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181212/59482e7f/attachment.htm>


More information about the gerrit-log mailing list