This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Max gerrit-no-reply at lists.osmocom.orgMax has posted comments on this change. ( https://gerrit.osmocom.org/12266 ) Change subject: vty: show subscriber: put() before printing the use count ...................................................................... Patch Set 1: (2 comments) Please clarify. https://gerrit.osmocom.org/#/c/12266/1/src/libmsc/msc_vty.c File src/libmsc/msc_vty.c: https://gerrit.osmocom.org/#/c/12266/1/src/libmsc/msc_vty.c@821 PS1, Line 821: argv[1]); If this taints the count than what about all other calls to get_vsub_by_argv()? https://gerrit.osmocom.org/#/c/12266/1/src/libmsc/msc_vty.c@830 PS1, Line 830: * and since it existed before we called _get() on it above. */ Are you referring to get_vsub_by_argv()? Better use function name - it's more likely to persist than relative positions. -- To view, visit https://gerrit.osmocom.org/12266 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id02b57b7ed299b010b9f8b9e809548eb1e6aa699 Gerrit-Change-Number: 12266 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-CC: Harald Welte <laforge at gnumonks.org> Gerrit-CC: Max <msuraev at sysmocom.de> Gerrit-Comment-Date: Wed, 12 Dec 2018 14:44:24 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181212/30990c10/attachment.htm>