Change in osmo-mgw[master]: drop/replace very weird logging in mgcp_client.c

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Wed Dec 12 13:49:27 UTC 2018


dexter has posted comments on this change. ( https://gerrit.osmocom.org/12269 )

Change subject: drop/replace very weird logging in mgcp_client.c
......................................................................


Patch Set 1: Code-Review+1

> Leaving +2 until dexter has a look at it.

I think this ok, the logging seems to be indeed strange since the for loop replaces all \r or \n with \0, this means the message will be chopped off very early. Now we should get a more complete message (as long as it is not longer than 255 chars.)


-- 
To view, visit https://gerrit.osmocom.org/12269
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6877ed7fd7dbe009b2ece8792d5160d040c1aaa
Gerrit-Change-Number: 12269
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Comment-Date: Wed, 12 Dec 2018 13:49:27 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181212/5e8c46f8/attachment.htm>


More information about the gerrit-log mailing list