Change in libosmocore[master]: add to osmo_sock_get_name*() API

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Wed Dec 12 12:49:09 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12268 )

Change subject: add to osmo_sock_get_name*() API
......................................................................


Patch Set 1: Code-Review+1

(3 comments)

https://gerrit.osmocom.org/#/c/12268/1/include/osmocom/core/socket.h
File include/osmocom/core/socket.h:

https://gerrit.osmocom.org/#/c/12268/1/include/osmocom/core/socket.h@63
PS1, Line 63: const char *osmo_sock_get_name2(int fd);
what about osmo_sock_get_name_static()?


https://gerrit.osmocom.org/#/c/12268/1/include/osmocom/core/socket.h@64
PS1, Line 64: int osmo_sock_get_name2_buf(char *str, size_t str_len, int fd);
no need to have a 2 here.


https://gerrit.osmocom.org/#/c/12268/1/src/socket.c
File src/socket.c:

https://gerrit.osmocom.org/#/c/12268/1/src/socket.c@796
PS1, Line 796:  *  \param[out] str  Destination string buffer.
2 whitespace here and in next line.



-- 
To view, visit https://gerrit.osmocom.org/12268
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ad89ac447c9c582742e70d082072bdd40a5a398
Gerrit-Change-Number: 12268
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 12 Dec 2018 12:49:09 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181212/fe234992/attachment.htm>


More information about the gerrit-log mailing list