Change in libosmocore[master]: LCLS, TS 48.008: add GCR IE encoding/decoding

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/12020 )

Change subject: LCLS, TS 48.008: add GCR IE encoding/decoding
......................................................................


Patch Set 18:

(1 comment)

https://gerrit.osmocom.org/#/c/12020/4/tests/gsm0808/gsm0808_test.c
File tests/gsm0808/gsm0808_test.c:

https://gerrit.osmocom.org/#/c/12020/4/tests/gsm0808/gsm0808_test.c@586
PS4, Line 586: {
No need to be bitter about it: it's not the first time people disagree with you (or me, or Pau...) nor the last.

> you dismiss a sound argument
If you find it sound it doesn't mean others would automatically share your opinion.

Here're some more details since you insist:

> memset() is the byte hacking way and I don't like it...
It's a standard function and your liking/disliking it is irrelevant and hardly a sound argument.

> just 'var = {0}' doesn't work you need to supply the type name to the compiler (unless it is a new variable declaration init...
Irrelevant in this case because "it's a new variable declaration init".

> the struct variable is part of ran_conn...
Irrelevant again - it's standalone struct which we initialize entirely.

> to write "{0}" means that I indicate the first item's value to be zero...
The only part of your link which is actually applicable to the code you're commenting on. Yes, initializing via {} is equivalent to {0} precisely because {} initialize entire thing with 0 and { x } initialize first byte with x and the rest with 0. And yes, it's "more general" if you will. But nobody have argued with those points to begin with. My point was (and still is) that it's easier to read the code because the 0 immediately reminds you how the rest is initialized. That's also seems to be preferred variant in libosmocore so far according to git grep.



-- 
To view, visit https://gerrit.osmocom.org/12020
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I82ce0207dc8de50689a8806c6471ad7fbae6219d
Gerrit-Change-Number: 12020
Gerrit-PatchSet: 18
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-CC: Stefan Sperling <stsp at stsp.name>
Gerrit-Comment-Date: Wed, 12 Dec 2018 12:46:30 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181212/4c0cf398/attachment.htm>