Change in osmo-ttcn3-hacks[master]: MGCP: fix pattern warning

[dexter]

dexter has posted comments on this change. ( https://gerrit.osmocom.org/12237 )

Change subject: MGCP: fix pattern warning
......................................................................


Patch Set 1:

(2 comments)

> Patch Set 2: Code-Review+1

https://gerrit.osmocom.org/#/c/12237/1/library/MGCP_Types.ttcn
File library/MGCP_Types.ttcn:

https://gerrit.osmocom.org/#/c/12237/1/library/MGCP_Types.ttcn@57
PS1, Line 57: 		variant "END('\n', '([\n])|(\n)')"
> IIUC that can just be '\n' now in that regex part, without the ()|() stuff?
As far as I know there is always a second separator line between MGCP and SDP. I might be wrong since I am no good with REGEX anyway...


https://gerrit.osmocom.org/#/c/12237/1/library/MGCP_Types.ttcn@94
PS1, Line 94: 		//variant "END('\r\n', '(\n)|(\r\n)')"
> (also drop this?)
(I would drop all commented lines in this file)



-- 
To view, visit https://gerrit.osmocom.org/12237
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I99948e4b82b5b4bd5b8f7c1a4c60a97fcab3c0eb
Gerrit-Change-Number: 12237
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Comment-Date: Wed, 12 Dec 2018 09:56:35 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181212/f1497ad5/attachment.htm>