Change in libosmocore[master]: LCLS, TS 48.008: add GCR IE encoding/decoding

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/12020 )

Change subject: LCLS, TS 48.008: add GCR IE encoding/decoding
......................................................................


Patch Set 18:

(2 comments)

https://gerrit.osmocom.org/#/c/12020/4/tests/gsm0808/gsm0808_test.c
File tests/gsm0808/gsm0808_test.c:

https://gerrit.osmocom.org/#/c/12020/4/tests/gsm0808/gsm0808_test.c@586
PS4, Line 586: {
> It's "better" using {0} for two reasons, but after reading in lots of places about the topic, there' […]
Since the opinions differ I'd rather keep the code as it is because I find it easier to read. I've read Neels argument but have not found it convincing.


https://gerrit.osmocom.org/#/c/12020/17/tests/gsm0808/gsm0808_test.c
File tests/gsm0808/gsm0808_test.c:

https://gerrit.osmocom.org/#/c/12020/17/tests/gsm0808/gsm0808_test.c@1864
PS17, Line 1864: 	void *ctx = talloc_named_const(NULL, 0, "gsm0808 test");
> and possibly trace the logging in expected stderr output

No output is expected on stderr as long as test passes.



-- 
To view, visit https://gerrit.osmocom.org/12020
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I82ce0207dc8de50689a8806c6471ad7fbae6219d
Gerrit-Change-Number: 12020
Gerrit-PatchSet: 18
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-CC: Stefan Sperling <stsp at stsp.name>
Gerrit-Comment-Date: Wed, 12 Dec 2018 09:53:43 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181212/718f0151/attachment.htm>