Change in osmo-msc[master]: vty: show subscriber: put() before printing the use count

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Dec 12 03:06:48 UTC 2018


Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/12266


Change subject: vty: show subscriber: put() before printing the use count
......................................................................

vty: show subscriber: put() before printing the use count

Do not show the VTY command's own use count during 'show subscriber <ID>'.

When using 'show subscriber msisdn 2023', I was surprised to see a use count of
2 and suspected a use count leak. With 'show subscriber cache' however, the use
count is 1.

So I realized it is the vty command's own use count that makes it two, besides
the lu_complete=true one.

Change-Id: Id02b57b7ed299b010b9f8b9e809548eb1e6aa699
---
M src/libmsc/msc_vty.c
1 file changed, 4 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/66/12266/1

diff --git a/src/libmsc/msc_vty.c b/src/libmsc/msc_vty.c
index 06e1139..9516752 100644
--- a/src/libmsc/msc_vty.c
+++ b/src/libmsc/msc_vty.c
@@ -826,10 +826,12 @@
 		return CMD_WARNING;
 	}
 
-	subscr_dump_full_vty(vty, vsub);
-
+	/* Do not taint the use count in the output. It will not become deallocated, since we are not multi-threaded,
+	 * and since it existed before we called _get() on it above. */
 	vlr_subscr_put(vsub);
 
+	subscr_dump_full_vty(vty, vsub);
+
 	return CMD_SUCCESS;
 }
 

-- 
To view, visit https://gerrit.osmocom.org/12266
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id02b57b7ed299b010b9f8b9e809548eb1e6aa699
Gerrit-Change-Number: 12266
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181212/63ba2558/attachment.htm>


More information about the gerrit-log mailing list