Change in osmo-msc[master]: move ASS-COMPL MGCP handling out of a_iface_bssap.c

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Dec 11 19:36:12 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12201 )

Change subject: move ASS-COMPL MGCP handling out of a_iface_bssap.c
......................................................................


Patch Set 3:

(1 comment)

This patch was reverted in 85cb2538f4cb4c6759824dae546564562ff3888e

https://gerrit.osmocom.org/#/c/12201/3/include/osmocom/msc/msc_mgcp.h
File include/osmocom/msc/msc_mgcp.h:

https://gerrit.osmocom.org/#/c/12201/3/include/osmocom/msc/msc_mgcp.h@27
PS3, Line 27: struct gsm0808_speech_codec;
> Yes, seems like osmocom/msc/ran_conn.h and osmocom/gsm/protocol/gsm_08_08. […]
it's better to just declare opaque structs where you can, to not pull in all sorts of dependencies "by accident"



-- 
To view, visit https://gerrit.osmocom.org/12201
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8137215c443239bddf3e69b5715839a365b73b6c
Gerrit-Change-Number: 12201
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name>
Gerrit-Comment-Date: Tue, 11 Dec 2018 19:36:12 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181211/18a39a35/attachment.htm>


More information about the gerrit-log mailing list