Change in osmocom-bb[master]: trx_toolkit/data_if.py: add optional legacy message coding flag

[Vadim Yanitskiy]

Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/12262


Change subject: trx_toolkit/data_if.py: add optional legacy message coding flag
......................................................................

trx_toolkit/data_if.py: add optional legacy message coding flag

Some transceivers (e.g. OsmoTRX) have inherited a rudiment from
OpenBTS - two dummy bytes at the end of every TRX2L1 message.
Despite they are absolutely useless, some L1 implementations,
such as trxcon and OpenBTS, still do expect them when
checking TRX2L1 message length.

Let's add an optional (disabled by default) argument to send_msg(),
that would enable adding those two dummy bytes.

Change-Id: I6b9a8b611ea1e9badc4d9ddf13aa9e237028e39a
---
M src/target/trx_toolkit/data_if.py
1 file changed, 6 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/62/12262/1

diff --git a/src/target/trx_toolkit/data_if.py b/src/target/trx_toolkit/data_if.py
index 45114ed..3366adc 100644
--- a/src/target/trx_toolkit/data_if.py
+++ b/src/target/trx_toolkit/data_if.py
@@ -60,7 +60,7 @@
 
 		return msg
 
-	def send_msg(self, msg):
+	def send_msg(self, msg, legacy = False):
 		# Validate a message
 		if not msg.validate():
 			raise ValueError("Message incomplete or incorrect")
@@ -68,5 +68,10 @@
 		# Generate TRX message
 		payload = msg.gen_msg()
 
+		# This is a rudiment from (legacy) OpenBTS transceiver,
+		# some L1 implementations still expect two dummy bytes.
+		if legacy:
+			payload += bytearray(2)
+
 		# Send message
 		self.send(payload)

-- 
To view, visit https://gerrit.osmocom.org/12262
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6b9a8b611ea1e9badc4d9ddf13aa9e237028e39a
Gerrit-Change-Number: 12262
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181211/680f4e5b/attachment.htm>